Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ByteBufferInputStream.read(byte[], int, int) to follow the contract #3752

Closed
wants to merge 1 commit into from
Closed

Make ByteBufferInputStream.read(byte[], int, int) to follow the contract #3752

wants to merge 1 commit into from

Conversation

leventov
Copy link
Member

No description provided.

ijuma
ijuma reviewed Aug 31, 2017
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It would be good to add a test in ByteBufferLogInputStreamTest to verify the fix.

@ijuma ijuma self-assigned this Dec 22, 2017
@ijuma ijuma added this to the 1.1.0 milestone Dec 22, 2017
@chia7712
Copy link
Contributor

@leventov Do you want to activate this PR? If not, I'd like to file a PR to complete it with a test case :)

@leventov
Copy link
Member Author

@chia7712 go for it

@chia7712
Copy link
Contributor

@leventov Thanks for your response. I'm going to close this PR. see https://issues.apache.org/jira/browse/KAFKA-10768 as follow-up

@chia7712 chia7712 closed this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma left review comments

Assignees

@ijuma ijuma

Labels
None yet
Projects
None yet
Milestone
1.1.0
3 participants
@leventov @chia7712 @ijuma