Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-5846; Used Singleton NoOpConsumerRebalanceListener in the Kafka… #3815

Closed
wants to merge 1 commit into from
Closed

KAFKA-5846; Used Singleton NoOpConsumerRebalanceListener in the Kafka… #3815

wants to merge 1 commit into from

Conversation

kamalcph
Copy link
Collaborator

@kamalcph kamalcph commented Sep 8, 2017

…Consumer#subscribe call.

  • I haven't removed the internal class 'NoOpConsumerRebalanceListener', as it might conflict with the existing users who's using it.

tedyu
tedyu reviewed Sep 8, 2017
View reviewed changes
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java
@@ -78,6 +78,14 @@
*/
public interface ConsumerRebalanceListener {

ConsumerRebalanceListener NO_OP = new ConsumerRebalanceListener() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be static.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think static is not required inside the interface.

@kamalcph
Copy link
Collaborator Author

retest this please

@kamalcph
Copy link
Collaborator Author

@ijuma
call for review.

@kamalcph
Copy link
Collaborator Author

retest this please

@kamalcph
Copy link
Collaborator Author

@ijuma @tedyu

Could you please review / merge the changes ? If there any additional changes required, please let me know.

@kamalcph kamalcph force-pushed the rebalance_listener branch 3 times, most recently from 47b6816 to c439856 Compare March 22, 2018 12:28
@kamalcph kamalcph force-pushed the rebalance_listener branch 2 times, most recently from 6e92c4a to 74ec32f Compare March 28, 2018 04:35
@kamalcph kamalcph force-pushed the rebalance_listener branch 2 times, most recently from 7ae28d3 to da247a7 Compare June 4, 2018 07:04
@kamalcph kamalcph closed this Oct 17, 2018
@kamalcph kamalcph deleted the rebalance_listener branch October 17, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedyu tedyu tedyu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kamalcph @tedyu