Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-5893: ResetIntegrationTest fails #3859

Closed
wants to merge 2 commits into from
Closed

KAFKA-5893: ResetIntegrationTest fails #3859

wants to merge 2 commits into from

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Sep 14, 2017

  • improve stderr output for better debugging

@mjsax
KAFKA-5893: ResetIntegrationTest fails
fa51ab0 
 - improve stderr output for better debugging
@mjsax
Copy link
Member Author

mjsax commented Sep 14, 2017 •
edited

This is WIP. I hope the build fails. We got quite some failing builds but the output only says:

Standard Error
ERROR: null
ERROR: null

Ie, the exception we catch has no error message. Printing the whole stack trace should shed some light on this.

\cc @guozhangwang @dguy @bbejeck

bbejeck
bbejeck approved these changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjsax LGTM

@dguy
Copy link
Contributor

dguy commented Sep 15, 2017

@mjsax, Did you want me to merge this? You said it is a WIP in your comment, so i'm unsure?

@mjsax
Copy link
Member Author

mjsax commented Sep 15, 2017

Well. This does not fix the issue that's why it's WIP -- we can merge to figure out the root cause (the change makes sense anyway). But we should not close the JIRA as resolved (-> WIP).

guozhangwang
guozhangwang reviewed Sep 16, 2017
View reviewed changes
core/src/main/scala/kafka/tools/StreamsResetter.java Outdated
@@ -124,6 +124,7 @@ public int run(final String[] args, final Properties config) {
} catch (final Throwable e) {
exitCode = EXIT_CODE_ERROR;
System.err.println("ERROR: " + e.getMessage());
e.printStackTrace(System.err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 126 above, maybe we can just call e.toString which will include the message string if it contains? otherwise LGTM

@guozhangwang
Copy link
Contributor

Is this failure easily reproducible locally, or only on Jenkins? I'd prefer to merge a PR that fixes the issue altogether with logging improvements. We can use jenkins bots to continuously trigger builds until it fails.

@mjsax
Copy link
Member Author

mjsax commented Sep 16, 2017

@guozhangwang Updated this PR. I could not reproduce it locally, so I guess we need to merge this to get more insight why it's failing.

@dguy
Copy link
Contributor

dguy commented Sep 18, 2017

retest this please

@guozhangwang
Copy link
Contributor

retest this please.

@guozhangwang
Copy link
Contributor

Merged to trunk

@asfgit asfgit closed this in b363901 Sep 18, 2017
@mjsax mjsax deleted the kafka-5893-reset-integration-test branch September 18, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guozhangwang guozhangwang guozhangwang left review comments

@bbejeck bbejeck bbejeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mjsax @dguy @guozhangwang @bbejeck