KAFKA-2711; SaslClientAuthenticator no longer needs KerberosNameParser in constructor #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ticator` Also refactor `KerberosNameParser` and `KerberosName` to make the code clearer.
|
Thanks for the patch. LGTM. |
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Aug 21, 2020
This PR drops the `FindQuorum` API and adds new logic to use `Fetch` for quorum discovery instead.
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Sep 29, 2022
…tions (apache#390) TICKET = LIKAFKA-45529 LI_DESCRIPTION = Sometimes, a leader host can become too busy to serve Fetch requests from followers within the default request timeout of 10s. The impact is that all followers experience the timeout and fall out of the ISR, resulting in UnderMinISR partitions. A proposed solution to this problem is to let the leader host request a leadership switch for the affected partitions. The leader host already knows what followers have been in the ISR, and thus can recommend a new leader to the controller. This PR is the 1st step toward that goal by adding a new API to support electing recommended leaders for partitions. Specifically, the PR includes the following changes adding support in the controller for electing the recommended leaders. The recommended leader must be alive and already in the ISR; changing the ElectLeadersRequest.json to add a new optional field that indicates the recommended leaders; exposing a new API in the KafkaAdminClient. EXIT_CRITERIA = We will likely propose this change as a KIP in upstream Kafka. Thus this hotfix can exit when the change is merged upstream and pulled in as part of a major release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor
KerberosNameParserandKerberosNameto make the codeclearer and easier to use when
shortNameis not needed.