KAFKA-5225: StreamsResetter doesn't allow custom Consumer properties #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Call for review @guozhangwang @bbejeck @dguy |
dguy
reviewed
Sep 27, 2017
| @@ -178,7 +186,7 @@ private void parseArguments(final String[] args) throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| private void maybeResetInputAndSeekToEndIntermediateTopicOffsets() { | |||
| private void maybeResetInputAndSeekToEndIntermediateTopicOffsets(final HashMap consumerConfig) { | |||
|
Added a test with SSL. \cc @ijuma |
ijuma
reviewed
Sep 29, 2017
| throw new IllegalArgumentException("Unknown security protocol: " + listenerConfig.toString()); | ||
| } | ||
| } | ||
| return kafka.config().hostName() + ":" + kafka.boundPort(ListenerName.forSecurityProtocol(securityProtocol)); |
There was a problem hiding this comment.
You can pass the listener name instead of the security protocol and remove a bunch of code.
|
Updated. |
dguy
reviewed
Sep 29, 2017
There was a problem hiding this comment.
Thanks @mjsax, one minor comment. However, is there a way we can share some of the test code between ResetIntegrationTest and ResetIntegrationWithSSLTest ? Seems like there are a lot of similarities? If you think it will distract from the test too much, i'm ok with it. Let me know.
| @Override | ||
| public void uncaughtException(Thread t, Throwable e) { | ||
| handlerReference.close(10, TimeUnit.SECONDS); | ||
| e.printStackTrace(System.err); |
|
Updated this. |
dguy
approved these changes
Oct 2, 2017
|
Merged to trunk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.