KAFKA-5958: Global stores access state restore listener #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @mjsax @dguy @guozhangwang |
bbejeck
changed the title
dguy
reviewed
Sep 27, 2017
| @@ -294,7 +298,7 @@ public void run() { | |||
|
|
|||
| private StateConsumer initialize() { | |||
| try { | |||
| final GlobalStateManager stateMgr = new GlobalStateManagerImpl(topology, consumer, stateDirectory); | |||
| final GlobalStateManager stateMgr = new GlobalStateManagerImpl(topology, consumer, stateDirectory, stateRestoreListener); | |||
There was a problem hiding this comment.
nit: should probably put the params on separate lines as it has exceeded the 120 char limit
| @@ -179,6 +179,7 @@ public void testStateGlobalThreadClose() throws Exception { | |||
| builder.globalTable("anyTopic"); | |||
| props.put(StreamsConfig.NUM_STREAM_THREADS_CONFIG, numThreads); | |||
| final KafkaStreams streams = new KafkaStreams(builder.build(), props); | |||
| streams.setGlobalStateRestoreListener(new MockStateRestoreListener()); | |||
There was a problem hiding this comment.
Do we need this? The test doesn't actually use or test it so it seems irrelevant
| @@ -452,7 +475,7 @@ public void shouldThrowLockExceptionIfIOExceptionCaughtWhenTryingToLockStateDir( | |||
| public boolean lockGlobalState(final int retry) throws IOException { | |||
| throw new IOException("KABOOM!"); | |||
| } | |||
| }); | |||
| }, null); | |||
There was a problem hiding this comment.
Should this be null? It seems that GlobalStateMangerImpl never expects it to be null.
| @@ -96,7 +98,7 @@ public void shouldThrowStreamsExceptionOnStartupIfExceptionOccurred() { | |||
| new StateDirectory("appId", TestUtils.tempDirectory().getPath(), time), | |||
| new Metrics(), | |||
| new MockTime(), | |||
| "clientId"); | |||
| "clientId", null); | |||
There was a problem hiding this comment.
new line for param and I think it should probably not be null
| @@ -220,7 +221,7 @@ public ProcessorTopologyTestDriver(final StreamsConfig config, | |||
| globalPartitionsByTopic.put(topicName, partition); | |||
| offsetsByTopicPartition.put(partition, new AtomicLong()); | |||
| } | |||
| final GlobalStateManagerImpl stateManager = new GlobalStateManagerImpl(globalTopology, globalConsumer, stateDirectory); | |||
| final GlobalStateManagerImpl stateManager = new GlobalStateManagerImpl(globalTopology, globalConsumer, stateDirectory, stateRestoreListener); | |||
There was a problem hiding this comment.
nit: params on sep line as char limit exceeded?
|
@dguy thanks for review, updated for comments |
dguy
reviewed
Sep 27, 2017
| @@ -179,6 +179,7 @@ public void testStateGlobalThreadClose() throws Exception { | |||
| builder.globalTable("anyTopic"); | |||
| props.put(StreamsConfig.NUM_STREAM_THREADS_CONFIG, numThreads); | |||
| final KafkaStreams streams = new KafkaStreams(builder.build(), props); | |||
| streams.setGlobalStateRestoreListener(null); | |||
|
updated this |
dguy
approved these changes
Sep 28, 2017
|
merged to trunk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.