Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-6102: Consolidate MockTime implementations between connect and … #4105

Closed
wants to merge 1 commit into from
Closed

KAFKA-6102: Consolidate MockTime implementations between connect and … #4105

wants to merge 1 commit into from

Conversation

cmccabe
Copy link
Contributor

@cmccabe cmccabe commented Oct 20, 2017

…clients

rhauch
rhauch approved these changes Oct 23, 2017
View reviewed changes
Copy link
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@asfgit
Copy link

asfgit commented Nov 14, 2017

FAILURE
8067 tests run, 5 skipped, 2 failed.
--none--

2 similar comments
@asfgit
Copy link

asfgit commented Nov 14, 2017

FAILURE
8067 tests run, 5 skipped, 2 failed.
--none--

@asfgit
Copy link

asfgit commented Nov 14, 2017

FAILURE
8067 tests run, 5 skipped, 2 failed.
--none--

@cmccabe
Copy link
Contributor Author

cmccabe commented Dec 8, 2017

retest this please

@rhauch
Copy link
Contributor

rhauch commented Dec 14, 2017

@hachikuji this looks great and is ready for a merge. Would you mind?

hachikuji
hachikuji approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the cleanup.

@asfgit asfgit closed this in 616321b Dec 14, 2017
@cmccabe cmccabe deleted the KAFKA-6102 branch May 20, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhauch rhauch rhauch approved these changes

@hachikuji hachikuji hachikuji approved these changes

Assignees
No one assigned
Labels
connect
Projects
None yet
Milestone
No milestone
5 participants
@cmccabe @asfgit @rhauch @hachikuji @kkonstantine