Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-6100: Down-grade RocksDB to 5.7.3 #4136

Closed
wants to merge 1 commit into from
Closed

KAFKA-6100: Down-grade RocksDB to 5.7.3 #4136

wants to merge 1 commit into from

Conversation

guozhangwang
Copy link
Contributor

No description provided.

@guozhangwang
Copy link
Contributor Author

@vahidhashemian @dguy @bbejeck @mjsax

@mjsax
Copy link
Member

mjsax commented Oct 26, 2017

Can we run systems test for this?

@guozhangwang
Copy link
Contributor Author

Yup: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1117

vahidhashemian
vahidhashemian approved these changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@vahidhashemian vahidhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my Windows VM and did not experience the issue reported in KAFKA-6100.

dguy
dguy approved these changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the system tests etc pass

bbejeck
bbejeck reviewed Oct 26, 2017
View reviewed changes
Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming system test pass.

@guozhangwang
Copy link
Contributor Author

retest this please

@guozhangwang
Copy link
Contributor Author

https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1118/ passed. Merging to 1.0 and trunk.

@asfgit asfgit closed this in ea6a67a Oct 26, 2017
asfgit pushed a commit that referenced this pull request Oct 26, 2017
@guozhangwang
KAFKA-6100: Down-grade RocksDB to 5.7.3
109a60c 
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Vahid Hashemian <vahidhashemian@us.ibm.com>, Damian Guy <damian.guy@gmail.com>, Bill Bejeck <bill@confluent.io>

Closes #4136 from guozhangwang/K6100-rocksdb-580-regression

(cherry picked from commit ea6a67a)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
@sagar0 sagar0 mentioned this pull request Oct 27, 2017
Closed
@guozhangwang guozhangwang deleted the K6100-rocksdb-580-regression branch November 6, 2017 22:46
jeqo pushed a commit to jeqo/kafka that referenced this pull request Nov 16, 2017
@guozhangwang @jeqo
KAFKA-6100: Down-grade RocksDB to 5.7.3
a1755cd 
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Vahid Hashemian <vahidhashemian@us.ibm.com>, Damian Guy <damian.guy@gmail.com>, Bill Bejeck <bill@confluent.io>

Closes apache#4136 from guozhangwang/K6100-rocksdb-580-regression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbejeck bbejeck bbejeck left review comments

@dguy dguy dguy approved these changes

@vahidhashemian vahidhashemian vahidhashemian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@guozhangwang @mjsax @dguy @bbejeck @vahidhashemian