KAFKA-6233 :Removed unnecessary null check

[sagarchavan3172]

Removed unnecessary null check
if (encodingValue != null && encodingValue instanceof String)
null instanceof String returns false hence replaced the check with
if (encodingValue instanceof String)

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[asfgit]

FAILURE
7973 tests run, 5 skipped, 1 failed.
--none--

[asfgit]

SUCCESS
8081 tests run, 5 skipped, 0 failed.
--none--

[asfgit]

SUCCESS
8081 tests run, 5 skipped, 0 failed.
--none--

[sagarchavan3172]

Failure is unrelated.
This is my first PR for kafka.
@guozhangwang @dguy @bbejeck Can you please review? Thanks

[guozhangwang]

encodingValue can still be null right, as configs.get(..) could still return a null.

[sagarchavan3172]

yes encoding value can be null but the instanceof operator does not return
null pointer exception for encodingValue==null.
Instead if encodingValue==null, (encodingValue instanceof String) returns
false which is the desired behavior.
Thanks for the quick reply.

[sagarchavan3172]

yes encoding value can be null but the instanceof operator does not return null pointer exception for encodingValue==null. Instead if encodingValue==null, (encodingValue instanceof String) returns false which is the desired behavior. Thanks for the quick reply.

…

On Sat, Nov 18, 2017 at 2:58 PM, Guozhang Wang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In clients/src/main/java/org/apache/kafka/common/serialization/ StringSerializer.java <#4232 (comment)>: > @@ -34,7 +34,7 @@ public void configure(Map<String, ?> configs, boolean isKey) { Object encodingValue = configs.get(propertyName); if (encodingValue == null) encodingValue = configs.get("serializer.encoding"); - if (encodingValue != null && encodingValue instanceof String) encodingValue can still be null right, as configs.get(..) could still return a null. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4232 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AekdFSfo0toZQRRz_Kt9dvvr0in-2Mg3ks5s32EEgaJpZM4QjJVZ> .