Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: improve error message for Streams test #4253

Closed
wants to merge 1 commit into from
Closed

MINOR: improve error message for Streams test #4253

wants to merge 1 commit into from

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Nov 22, 2017

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mjsax
Copy link
Member Author

mjsax commented Nov 22, 2017

Call for review @bbejeck @guozhangwang @dguy

bbejeck
bbejeck approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mjsax LGTM

asfgit pushed a commit that referenced this pull request Nov 26, 2017
@mjsax @guozhangwang
MINOR: improve error message for Streams test
53c9dd3 
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>

Closes #4253 from mjsax/minor-imporve-error-message

(cherry picked from commit 8f6a372)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
@guozhangwang
Copy link
Contributor

LGTM. Merged to trunk and 1.0.

@asfgit asfgit closed this in 8f6a372 Nov 26, 2017
@mjsax mjsax deleted the minor-imporve-error-message branch November 27, 2017 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbejeck bbejeck bbejeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mjsax @guozhangwang @bbejeck