Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-4827: Porting fix for KAFKA-4827 to v0.10 and v0.11 #4272

Closed
wants to merge 3 commits into from

Conversation

wicknicks
Copy link
Contributor

Back porting the fix in this PR (#4205) to v0.10 and v0.11.

Signed-off-by: Arjun Satish <arjun@confluent.io>
Also, update the tests to pass some additional characters in the connector
name along with adding a decode step using the URI class.

Signed-off-by: Arjun Satish <arjun@confluent.io>
Signed-off-by: Arjun Satish <arjun@confluent.io>
@wicknicks
Copy link
Contributor Author

retest this please

@wicknicks
Copy link
Contributor Author

@ewencp, @rhauch this is the backport for the PR for KAFKA-4827 (https://github.com/apache/kafka/pull/4205/files)

@wicknicks
Copy link
Contributor Author

retest this please

Copy link
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wicknicks
Copy link
Contributor Author

retest this please

1 similar comment
@ewencp
Copy link
Contributor

ewencp commented Nov 29, 2017

retest this please

@wicknicks wicknicks changed the base branch from 0.10.0 to 0.10.2 November 29, 2017 02:22
@wicknicks wicknicks changed the base branch from 0.10.2 to 0.10.0 November 29, 2017 02:22
@asfgit
Copy link

asfgit commented Nov 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3778/
Test FAILed (JDK 7 and Scala 2.10).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants