KAFKA-6326: when broker is unavailable, fast revover #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonhong
commented
Dec 7, 2017
leonhong
commented
- when broker is unavailable(such as broker's machine is down), controller will wait 30 sec timeout by dedault. it seems to be that the timeout waiting is not necessary. It will be increase the MTTR of dead broker .
|
@hachikuji @ijuma @huxihx ping... |
leonhong
changed the title
tedyu
reviewed
Dec 7, 2017
| @@ -76,6 +75,30 @@ public static boolean awaitReady(KafkaClient client, Node node, Time time, long | |||
| return client.isReady(node, attemptStartTime); | |||
| } | |||
|
|
|||
| public static boolean awaitReady(KafkaClient client, Node node, Time time, long timeoutMs, Boolean fastTimeout) throws IOException { | |||
There was a problem hiding this comment.
why use Boolean instead of primitive ?
There was a problem hiding this comment.
@tedyu Boolean 's type is reference?
There was a problem hiding this comment.
Seems the fastTimeout should be thread-safe since it will be accessed by both RequestSendThread and controller event thread. Perhaps volatile is a least requirement for memory visibility.
There was a problem hiding this comment.
I changed the type to boolean here (and on line 89) - compilation passed.
This would avoid unboxing.
|
In |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.