KAFKA-5891: Proper handling of LogicalTypes in Cast #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maver1ck
changed the title
|
@ewencp is there an estimate on this PR? |
|
@maver1ck Thanks for the patch. Would you mind adding a test case? |
|
@hachikuji |
|
@hachikuji |
rhauch
reviewed
Mar 20, 2018
| @@ -331,6 +335,7 @@ public void castFieldsWithSchema() { | |||
| assertEquals(true, ((Struct) transformed.value()).schema().field("float64").schema().defaultValue()); | |||
| assertEquals((byte) 1, ((Struct) transformed.value()).get("boolean")); | |||
| assertEquals(42, ((Struct) transformed.value()).get("string")); | |||
| assertEquals(new Date(0), ((Struct) transformed.value()).get("timestamp")); | |||
There was a problem hiding this comment.
Since this PR modifies the logic that builds the schema, it might be good to add a block that tests the schemas of each field in the resulting schema. Something like the following (which I don't know if it compiles):
Schema transformedSchema = ((Struct) transformed.value()).schema();
assertEquals(Schema.INT16_SCHEMA, transformedSchema.field("int8").schema());
assertEquals(Schema.OPTIONAL_INT32_SCHEMA, transformedSchema.field("int16").schema());
assertEquals(Schema.INT64_SCHEMA, transformedSchema.field("int32").schema());
assertEquals(Schema.BOOLEAN_SCHEMA, transformedSchema.field("int64").schema());
assertEquals(Schema.FLOAT64_SCHEMA, transformedSchema.field("float32").schema());
assertEquals(Schema.BOOLEAN_SCHEMA, transformedSchema.field("float64").schema());
assertEquals(Schema.INT8_SCHEMA, transformedSchema.field("boolean").schema());
assertEquals(Schema.INT32_SCHEMA, transformedSchema.field("string").schema());
assertEquals(Schema.OPTIONAL_INT32_SCHEMA, transformedSchema.field("optional").schema());
// The following fields are not changed
//assertEquals(Timestamp.SCHEMA, transformedSchema.field("timestamp").schema());
|
@maver1ck, any thoughts on the previous suggestion I had regarding adding a few more checks in the tests? |
3 tasks
hachikuji
pushed a commit
that referenced
this pull request
Aug 20, 2018
Currently logical types are dropped during Cast Transformation. This patch fixes this behaviour. Reviewers: Randall Hauch <rhauch@gmail.com>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
Aug 20, 2018
Currently logical types are dropped during Cast Transformation. This patch fixes this behaviour. Reviewers: Randall Hauch <rhauch@gmail.com>, Jason Gustafson <jason@confluent.io>
rayokota
added a commit
to rayokota/kafka
that referenced
this pull request
Aug 20, 2018
hachikuji
pushed a commit
that referenced
this pull request
Aug 20, 2018
Currently logical types are dropped during Cast Transformation. This patch fixes this behaviour. Reviewers: Randall Hauch <rhauch@gmail.com>, Jason Gustafson <jason@confluent.io>
Pengxiaolong
pushed a commit
to Pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Currently logical types are dropped during Cast Transformation. This patch fixes this behaviour. Reviewers: Randall Hauch <rhauch@gmail.com>, Jason Gustafson <jason@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently logical types are dropped during Cast Transformation.
This patch fixes this behaviour.
Committer Checklist (excluded from commit message)