Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-6538: Fixed RocksDBStore to enhance processor state exceptions with more context #4846

Conversation

jadireddi
Copy link
Contributor

https://issues.apache.org/jira/browse/KAFKA-6538
Fixed against Base:1.1 version.
Fixed Class:RocksDBStore to enhance Processor State Exception containing Key/Value values as Bytes/byte[] to Bytes/Bytes form in the error message for displaying more useful context .

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@jadireddi
Copy link
Contributor Author

jadireddi commented Apr 10, 2018

Hi @mjsax ,
Could you please review PR and let me know if any changes need.

@mjsax
Copy link
Member

mjsax commented Apr 12, 2018

Thanks for the PR @jadireddi .

Two comments:

  1. The PR should be against trunk -- we can cherry-pick it later to 1.1 branch
  2. The PR does not yet address the actual issue: wrapping byte[] in Bytes does not provide value to the user, as the error message will still show binary data that is not readable by humans. Because RocksDBStore does not contain deserializers we should catch the exception in the caller and throw a new exception with human readable key/value information. The caller should know the original key/value.

@mjsax
Copy link
Member

mjsax commented May 29, 2018

@jadireddi What is the status of this PR?

@jadireddi
Copy link
Contributor Author

@mjsax Working on this PR. Would be sending for review you in a day or so.

@jadireddi
Copy link
Contributor Author

As the branch created against Base:1.1 version. Closing this pull.
Changes are being taken against pull: #5103

@jadireddi jadireddi closed this May 31, 2018
@jadireddi jadireddi deleted the KAFKA-6538;-Enhance-ByteStore-exp-with-more-context-info branch May 31, 2018 05:17
@mjsax mjsax added the streams label Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants