Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-6825: Make StreamsConfig#DEFAULT_PRODUCTION_EXCEPTION_HANDLER_CLASS_CONFIG public #4929

Conversation

guozhangwang
Copy link
Contributor

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@guozhangwang guozhangwang requested review from dguy and mjsax April 25, 2018 15:40
@guozhangwang guozhangwang changed the title HOTFIX: Make StreamsConfig#DEFAULT_PRODUCTION_EXCEPTION_HANDLER_CLASS_CONFIG public KAFKA-6825: Make StreamsConfig#DEFAULT_PRODUCTION_EXCEPTION_HANDLER_CLASS_CONFIG public Apr 25, 2018
@guozhangwang
Copy link
Contributor Author

Should be merged into 1.1 as well.

Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjsax
Copy link
Member

mjsax commented Apr 30, 2018

Retest this please

@guozhangwang guozhangwang merged commit 31ce3a2 into apache:trunk May 2, 2018
guozhangwang added a commit that referenced this pull request May 2, 2018
…LASS_CONFIG public (#4929)

Reviewers: Matthias J Sax <matthias@confluentio>
@guozhangwang
Copy link
Contributor Author

Thanks @mjsax Cherry-picked to 1.1 as well.

ying-zheng pushed a commit to ying-zheng/kafka that referenced this pull request Jul 6, 2018
…LASS_CONFIG public (apache#4929)

Reviewers: Matthias J Sax <matthias@confluentio>
@guozhangwang guozhangwang deleted the KHotfix-default-producer-exception-handler-public branch April 24, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants