KAFKA-2813: selector doesn't close socket connection on non-IOExceptions #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw e; | ||
| } | ||
| while ((networkReceive = channel.read()) != null) | ||
| addToStagedReceives(channel, networkReceive); |
There was a problem hiding this comment.
Should we remove the @throws InvalidReceiveException in the comments of poll() then?
|
Will this change will make another caller of Selector, Sender.run(), to not throw Exceptions any more? (line 130) |
|
LGTM. @junrao, you can commit after system tests pass on this branch 👍 |
|
Sender may not get exception from Selector, but can get it from other places. However, it seems that we need to clean up Selectable since it never throws IOException in poll(). Will file a followup jira for that. |
|
LGTM. |
asfgit
pushed a commit
that referenced
this pull request
Nov 12, 2015
Patched Selector.poll() to close the connection on any exception. Author: Jun Rao <junrao@gmail.com> Reviewers: Guozhang Wang <wangguoz@gmail.com>, Gwen Shapira <cshapi@gmail.com> Closes #501 from junrao/KAFKA-2813 (cherry picked from commit 3fd168d) Signed-off-by: Jun Rao <junrao@gmail.com>
junrao
referenced
this pull request
in confluentinc/kafka
Nov 18, 2015
Patched Selector.poll() to close the connection on any exception. Author: Jun Rao <junrao@gmail.com> Reviewers: Guozhang Wang <wangguoz@gmail.com>, Gwen Shapira <cshapi@gmail.com> Closes #501 from junrao/KAFKA-2813
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patched Selector.poll() to close the connection on any exception.