New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KAFKA-6930] Update KafkaZkClient debug log #5061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Left a minor suggestion.
@@ -597,7 +597,7 @@ class KafkaZkClient private (zooKeeperClient: ZooKeeperClient, isSecure: Boolean | |||
setDataResponse.resultCode match { | |||
case Code.OK => | |||
debug("Conditional update of path %s with value %s and expected version %d succeeded, returning the new version: %d" | |||
.format(path, data, expectVersion, setDataResponse.stat.getVersion)) | |||
.format(path, new String(data), expectVersion, setDataResponse.stat.getVersion)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use Utils.utf8
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ijuma thanks fixed ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
retest this please |
Merged to trunk and 1.1. |
…5061) Reviewers: Ismael Juma <ismael@juma.me.uk>
…pache#5061) Reviewers: Ismael Juma <ismael@juma.me.uk>
KAFKA-6930 | Update KafkaZkClient debug log
Committer Checklist (excluded from commit message)