MINOR: Fix building from subproject directory #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
granthenke
force-pushed
the
minor
branch
3 times, most recently
from
999ea36
to
6108c2d
Compare
|
@granthenke LGTM, and I'd like to see this merged since it looks like it'll fix a problem I've had since checkstyle was added where IntelliJ tried to use the wrong path to the import-control.xml file when building only one of the subprojects. |
This patch fixes some releative paths so bulding from a subproject directory like ($rootDir/core) will not fail
|
LGTM, merged into trunk. |
|
Thanks for the review and merge @guozhangwang! |
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
…sted/configured so. (apache#509)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes some releative paths so bulding from a subproject directory like ($rootDir/core) will not fail