KAFKA-2807: Fix Kafka Connect packaging and move VerifiableSource/Sink into runtime jar. #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k into runtime jar. Gradle does not handle subprojects with the same name (top-level tools vs connect/tools) properly, making the dependency impossible to express correctly since we need to move the ThroughputThrottler class into the top level tools project. Moving the current set of tools into the runtime jar works fine since they are only used for system tests at the moment.
|
The issue with the original patch was also very easy to miss because if you had built the project before, you'd have stale jar files that would make it look like everything continues to run ok. I checked this out into a fresh copy of the repo and ran the tests to make sure it works. |
|
LGTM. |
ewencp
referenced
this pull request
in confluentinc/kafka
Nov 18, 2015
…k into runtime jar. Gradle does not handle subprojects with the same name (top-level tools vs connect/tools) properly, making the dependency impossible to express correctly since we need to move the ThroughputThrottler class into the top level tools project. Moving the current set of tools into the runtime jar works fine since they are only used for system tests at the moment. Author: Ewen Cheslack-Postava <me@ewencp.org> Reviewers: Gwen Shapira Closes #512 from ewencp/kafka-2807-redux
granders
referenced
this pull request
in confluentinc/kafka
Mar 1, 2016
…k into runtime jar. Gradle does not handle subprojects with the same name (top-level tools vs connect/tools) properly, making the dependency impossible to express correctly since we need to move the ThroughputThrottler class into the top level tools project. Moving the current set of tools into the runtime jar works fine since they are only used for system tests at the moment. Author: Ewen Cheslack-Postava <me@ewencp.org> Reviewers: Gwen Shapira Closes #512 from ewencp/kafka-2807-redux
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle does not handle subprojects with the same name (top-level tools vs
connect/tools) properly, making the dependency impossible to express correctly
since we need to move the ThroughputThrottler class into the top level tools
project. Moving the current set of tools into the runtime jar works fine since
they are only used for system tests at the moment.