Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-7009: Suppress the Reflections log warning messages in system tests #5151

Closed
wants to merge 1 commit into from
Closed

KAFKA-7009: Suppress the Reflections log warning messages in system tests #5151

wants to merge 1 commit into from

Conversation

rhauch
Copy link
Contributor

@rhauch rhauch commented Jun 6, 2018 •
edited

This could be backported to older branches to reduce the extra log warning messages there, too.

Running Connect system tests in this branch builder job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1773/

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rhauch
Copy link
Contributor Author

rhauch commented Jun 6, 2018

@ewencp, @kkonstantine: would appreciate a review.

@rhauch
Copy link
Contributor Author

rhauch commented Jun 6, 2018

Retest this please.

kkonstantine
kkonstantine approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@kkonstantine kkonstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhauch
Copy link
Contributor Author

rhauch commented Jun 6, 2018

The build passed on JDK 10, but failed on a completely unrelated Kafka broker test on JDK 8.

@rhauch rhauch changed the base branch from trunk to 2.0 June 6, 2018 21:25
@rhauch rhauch changed the base branch from 2.0 to trunk June 6, 2018 21:25
@rhauch
Copy link
Contributor Author

rhauch commented Jun 7, 2018

@hachikuji or @ewencp, would you mind reviewing and merging as far back as appropriate?

ewencp
ewencp approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like this will merge back to 0.10.0 and seems reasonable back that far, so I'll merge it through all those versions.

ewencp pushed a commit that referenced this pull request Jun 13, 2018
@rhauch @ewencp
KAFKA-7009: Suppress the Reflections log warning messages in system t…
f82b022 
…ests

This could be backported to older branches to reduce the extra log warning messages there, too.

Running Connect system tests in this branch builder job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1773/

Author: Randall Hauch <rhauch@gmail.com>

Reviewers: Konstantine Karantasis <konstantine@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #5151 from rhauch/kafka-7009

(cherry picked from commit 7a1f555)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
ewencp pushed a commit that referenced this pull request Jun 13, 2018
@rhauch @ewencp
KAFKA-7009: Suppress the Reflections log warning messages in system t…
369f1d7 
…ests

This could be backported to older branches to reduce the extra log warning messages there, too.

Running Connect system tests in this branch builder job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1773/

Author: Randall Hauch <rhauch@gmail.com>

Reviewers: Konstantine Karantasis <konstantine@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #5151 from rhauch/kafka-7009

(cherry picked from commit 7a1f555)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
ewencp pushed a commit that referenced this pull request Jun 13, 2018
@rhauch @ewencp
KAFKA-7009: Suppress the Reflections log warning messages in system t…
6955969 
…ests

This could be backported to older branches to reduce the extra log warning messages there, too.

Running Connect system tests in this branch builder job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1773/

Author: Randall Hauch <rhauch@gmail.com>

Reviewers: Konstantine Karantasis <konstantine@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #5151 from rhauch/kafka-7009

(cherry picked from commit 7a1f555)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
ewencp pushed a commit that referenced this pull request Jun 13, 2018
@rhauch @ewencp
KAFKA-7009: Suppress the Reflections log warning messages in system t…
689bac3 
…ests

This could be backported to older branches to reduce the extra log warning messages there, too.

Running Connect system tests in this branch builder job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1773/

Author: Randall Hauch <rhauch@gmail.com>

Reviewers: Konstantine Karantasis <konstantine@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #5151 from rhauch/kafka-7009

(cherry picked from commit 7a1f555)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
ewencp pushed a commit that referenced this pull request Jun 13, 2018
@rhauch @ewencp
KAFKA-7009: Suppress the Reflections log warning messages in system t…
24d0d33 
…ests

This could be backported to older branches to reduce the extra log warning messages there, too.

Running Connect system tests in this branch builder job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1773/

Author: Randall Hauch <rhauch@gmail.com>

Reviewers: Konstantine Karantasis <konstantine@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #5151 from rhauch/kafka-7009

(cherry picked from commit 7a1f555)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
@ewencp ewencp closed this in 7a1f555 Jun 13, 2018
ying-zheng pushed a commit to ying-zheng/kafka that referenced this pull request Jul 6, 2018
@rhauch @ying-zheng
KAFKA-7009: Suppress the Reflections log warning messages in system t…
56a1c23 
…ests

This could be backported to older branches to reduce the extra log warning messages there, too.

Running Connect system tests in this branch builder job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1773/

Author: Randall Hauch <rhauch@gmail.com>

Reviewers: Konstantine Karantasis <konstantine@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes apache#5151 from rhauch/kafka-7009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewencp ewencp ewencp approved these changes

@kkonstantine kkonstantine kkonstantine approved these changes

Assignees
No one assigned
Labels
connect
Projects
None yet
Milestone
No milestone
3 participants
@rhauch @ewencp @kkonstantine