Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7067:Include connector configs added in KIP-297 and KIP-298 in the system test assertion #5242

Merged
merged 1 commit into from Jun 18, 2018

Conversation

mageshn
Copy link
Contributor

@mageshn mageshn commented Jun 17, 2018

The new connector configs added in KIP-297 and KIP-298 would need to be updated in the connect_rest_test.py so that the expected results match the actual.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@wicknicks wicknicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix, @mageshn!

Copy link
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mageshn
Copy link
Contributor Author

mageshn commented Jun 18, 2018

@ewencp can you please review and merge this to trunk & 2.0

Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@mageshn
Copy link
Contributor Author

mageshn commented Jun 18, 2018

retest this please

@hachikuji hachikuji merged commit fc81acb into apache:trunk Jun 18, 2018
hachikuji pushed a commit that referenced this pull request Jun 18, 2018
…5242)

The new connector configs added in  KIP-297 and KIP-298 need to be updated in the connect_rest_test.py so that the expected results match the actual.
ying-zheng pushed a commit to ying-zheng/kafka that referenced this pull request Jul 6, 2018
…pache#5242)

The new connector configs added in  KIP-297 and KIP-298 need to be updated in the connect_rest_test.py so that the expected results match the actual.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants