KAFKA-2811: add standby tasks #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2015 10:51
| @@ -54,6 +54,10 @@ | |||
| public static final String NUM_STREAM_THREADS_CONFIG = "num.stream.threads"; | |||
| private static final String NUM_STREAM_THREADS_DOC = "The number of threads to execute stream processing."; | |||
|
|
|||
| /** <code>num.stream.threads</code> */ | |||
| public static final String NUM_STANDBY_REPLICAS_CONFIG = "num.standby.replicas"; | |||
| private static final String NUM_STANDBY_REPLICAS_DOC = "The number of standby replicas."; | |||
There was a problem hiding this comment.
"... for each stream task"?
| String storeName = entry.getKey(); | ||
| TopicPartition storePartition = new TopicPartition(storeName, partition); | ||
|
|
||
| long offset = -1; |
There was a problem hiding this comment.
offset is not assigned after initialized to -1.
There was a problem hiding this comment.
oops. I will fix it.
|
changed changeLogOffsets() -> checkpointedOffsets() which returns all change log partitions of persistent store and their checkpointed offsets. If a checkpoint offset is missing in the checkpoint file, -1L is used. The restored offsets are no longer consulted. |
| } | ||
| } | ||
|
|
||
| /** | ||
| * Commit the state of a task | ||
| * Commit the state of an task |
|
LGTM, thanks. |
ymatsuda
referenced
this pull request
in confluentinc/kafka
Nov 18, 2015
guozhangwang * added a new config param "num.standby.replicas" (the default value is 0). * added a new abstract class AbstractTask * added StandbyTask as a subclass of AbstractTask * modified StreamTask to a subclass of AbstractTask * StreamThread * standby tasks are created by calling StreamThread.addStandbyTask() from onPartitionsAssigned() * standby tasks are destroyed by calling StreamThread.removeStandbyTasks() from onPartitionRevoked() * In addStandbyTasks(), change log partitions are assigned to restoreConsumer. * In removeStandByTasks(), change log partitions are removed from restoreConsumer. * StreamThread polls change log records using restoreConsumer in the runLoop with timeout=0. * If records are returned, StreamThread calls StandbyTask.update and pass records to each standby tasks. Author: Yasuhiro Matsuda <yasuhiro@confluent.io> Reviewers: Guozhang Wang Closes #526 from ymatsuda/standby_task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guozhangwang