KAFKA-2847; Remove principal builder class from client configs #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it would be good to use it for SASL too and that may require the interface to be changed.
… for `SecurityProtocol.SSL`
|
./gradlew test passed locally |
| @@ -57,8 +55,7 @@ public void configure(Map<String, ?> configs) throws KafkaException { | |||
| try { | |||
| this.configs = configs; | |||
| this.loginManager = LoginManager.acquireLoginManager(loginType, configs); | |||
| this.principalBuilder = (PrincipalBuilder) Utils.newInstance((Class<?>) configs.get(SslConfigs.PRINCIPAL_BUILDER_CLASS_CONFIG)); | |||
| this.principalBuilder.configure(configs); | |||
| this.principalBuilder = ChannelBuilders.createPrincipalBuilder(configs); | |||
There was a problem hiding this comment.
It seems that we don't need to maintain principalBuilder in SaslChannelBuilder since both SaslServerAuthenticator and SaslClientAuthenticator ignore principalBuilder in configure().
There was a problem hiding this comment.
OK, passing null to configure as requested.
…t use it As suggested by Jun.
asfgit
pushed a commit
that referenced
this pull request
Nov 17, 2015
Also mark `PrincipalBuilder` as `Unstable` and tweak docs. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Jun Rao <junrao@gmail.com> Closes #542 from ijuma/kafka-2847-remove-principal-builder-class-from-client-configs (cherry picked from commit 52d5e88) Signed-off-by: Jun Rao <junrao@gmail.com>
ijuma
referenced
this pull request
in confluentinc/kafka
Nov 18, 2015
Also mark `PrincipalBuilder` as `Unstable` and tweak docs. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Jun Rao <junrao@gmail.com> Closes #542 from ijuma/kafka-2847-remove-principal-builder-class-from-client-configs
ijuma
deleted the
kafka-2847-remove-principal-builder-class-from-client-configs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also mark
PrincipalBuilderasUnstableand tweak docs.