Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-7237: Add explicit FATAL marker to log messages #5447

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-7237: Add explicit FATAL marker to log messages #5447

wants to merge 2 commits into from

Conversation

stanislavkozlovski
Copy link
Contributor

@stanislavkozlovski
Copy link
Contributor Author

cc @rajinisivaram @ijuma
Do you believe this is sufficient or might there be more logs I'm missing?

@ijuma
Copy link
Contributor

ijuma commented Aug 2, 2018

Not sure how useful fatal is. Maybe we should just drop that altogether. Whenever people look at the logs, they grep for ERROR so having an even more severe level maybe doesn't help much.

@ijuma
Copy link
Contributor

ijuma commented Nov 27, 2018

As I said before, I think we should just remove the fatal methods altogether.

@stanislavkozlovski
Copy link
Contributor Author

I agree. Now that I have more experience with Kafka I see that ERROR messages are rare enough to not justify a FATAL level

@ijuma
Copy link
Contributor

ijuma commented Jan 9, 2019

Can you please fix the conflict?

@stanislavkozlovski
Copy link
Contributor Author

Rebased 👍

@stanislavkozlovski
Copy link
Contributor Author

retest this please

@stanislavkozlovski
Copy link
Contributor Author

@ijuma are we good with this change if the tests pass?

@ijuma
Copy link
Contributor

ijuma commented Aug 26, 2019

retest this please

2 similar comments
@stanislavkozlovski
Copy link
Contributor Author

retest this please

@stanislavkozlovski
Copy link
Contributor Author

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stanislavkozlovski @ijuma