Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-7187 MockConsumer can fetch offsets based on timestamps #5561

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-7187 MockConsumer can fetch offsets based on timestamps #5561

wants to merge 1 commit into from
+27 −2

Conversation

nucatus
Copy link

@nucatus nucatus commented Aug 23, 2018

Add implementation for the MockConsumer, previously unexisting, for fetching offsets based on provided timestamps.

The unit test case was improved to include the testing of the fetching offsets based on timestamps.

Committer Checklist (excluded from commit message)

  • [ x ] Verify design and implementation
  • Verify test coverage and CI build status
  • [ x ] Verify documentation (including upgrade notes)

@dhruvilshah3
Copy link
Contributor

Retest this please

@chia7712
Copy link
Contributor

chia7712 commented Nov 4, 2020

@nucatus Thanks for your patch. This idea is LGTM. Could you rebase PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nucatus @dhruvilshah3 @chia7712