KAFKA-7373: Allow GetOffsetShell command to accept a configurations file #5617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's already a PR for this and a KIP too. |
|
My bad, should have searched first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetOffsetShell doesn't provide a mechanism to provide additional configuration for the underlying KafkaConsumer as does the
ConsoleConsumer. This leaves it unable to connect to a broker using SSL.This PR allows it to accept a client configuration file, subsequently allowing it to provide SSL configurations and connect to a broker.
I tested this manually. Trying to connect to a broker's SSL listener raised an out of memory error for me. After passing in the appropriate configurations via a config file, it connected successfully