MINOR: Fix remaining core, connect and clients tests to pass with Java 11 #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SslFactoryTest should use SslFactory to create SSLEngine - Use Mockito instead of EasyMock in ConsoleConsumerTest as one of the tests mocks a standard library class and EasyMock can't do that when Java 11 is used. SourceTaskOffsetCommitterTest in connect-runtime is the only test that still fails with Java 11.
ijuma
changed the title
3 tasks
rajinisivaram
approved these changes
Oct 10, 2018
There was a problem hiding this comment.
@ijuma Thanks for the PR. Left a minor comment, apart from that LGTM.
| PowerMock.replayAll(); | ||
|
|
||
| committer.schedule(taskId, task); | ||
| assertTrue(taskWrapper.hasCaptured()); | ||
| assertNotNull(taskWrapper.getValue()); | ||
| assertEquals(Utils.mkMap(mkEntry(taskId, commitFuture)), committers); |
There was a problem hiding this comment.
mkMap and mkEntry are both statics in Utils, why do we have static import for one and not the other? Anyway, perhaps this could just be Collections.singletonMap?
There was a problem hiding this comment.
Good point, changed to use singletonMap. Also removed some imports and an unnecessary @PrepareForTest.
|
One job passed and the other had an unrelated test failure: |
ijuma
added a commit
that referenced
this pull request
Oct 10, 2018
…a 11 (#5771) - SslFactoryTest should use SslFactory to create SSLEngine - Use Mockito instead of EasyMock in `ConsoleConsumerTest` as one of the tests mocks a standard library class and the latest released EasyMock version can't do that when Java 11 is used. - Avoid mocking `ConcurrentMap` in `SourceTaskOffsetCommitterTest` for similar reasons. As it happens, mocking is not actually needed here. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…a 11 (apache#5771) - SslFactoryTest should use SslFactory to create SSLEngine - Use Mockito instead of EasyMock in `ConsoleConsumerTest` as one of the tests mocks a standard library class and the latest released EasyMock version can't do that when Java 11 is used. - Avoid mocking `ConcurrentMap` in `SourceTaskOffsetCommitterTest` for similar reasons. As it happens, mocking is not actually needed here. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsoleConsumerTestas one ofthe tests mocks a standard library class and the latest released EasyMock
version can't do that when Java 11 is used.
ConcurrentMapinSourceTaskOffsetCommitterTestfor similar reasons. As it happens, mocking is not actually needed here.
Committer Checklist (excluded from commit message)