KAFKA-7513: Fix timing issue in SaslAuthenticatorFailureDelayTest #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
approved these changes
Oct 16, 2018
| @@ -53,7 +53,7 @@ | |||
| @RunWith(value = Parameterized.class) | |||
| public class SaslAuthenticatorFailureDelayTest { | |||
| private static final int BUFFER_SIZE = 4 * 1024; | |||
| private static MockTime time = new MockTime(50); | |||
| private static MockTime time = new MockTime(10); | |||
There was a problem hiding this comment.
Any reason why this isn't final?
There was a problem hiding this comment.
Made it final and changed to instance variable like we have in other tests.
|
Are any of the failures related? |
|
@ijuma Thanks for the review. The test failures don't look related. |
ijuma
approved these changes
Oct 16, 2018
|
@ijuma Thanks for the review. Test failures not related, merging to trunk and 2.1. |
rajinisivaram
added a commit
that referenced
this pull request
Oct 16, 2018
) Reduce tick interval of the mock timer and avoid large timer increments to avoid hitting idle expiry on the client-side before delayed close is processed by the server. Also reduce poll interval in the server to make the test complete faster (since delayed close is only processed when poll returns). Reviewers: Ismael Juma <ismael@juma.me.uk>
Pengxiaolong
pushed a commit
to Pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…ache#5805) Reduce tick interval of the mock timer and avoid large timer increments to avoid hitting idle expiry on the client-side before delayed close is processed by the server. Also reduce poll interval in the server to make the test complete faster (since delayed close is only processed when poll returns). Reviewers: Ismael Juma <ismael@juma.me.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce tick interval of the mock timer and avoid large timer increments to avoid hitting idle expiry on the client-side before delayed close is processed by the server. Also reduce poll interval in the server to make the test complete faster (since delayed close is only processed when poll returns).
Committer Checklist (excluded from commit message)