Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7653 [WIP] Add KeySerde and ValueSerde types #5938

Closed
wants to merge 1 commit into from

Conversation

mtranter
Copy link

KAFKA-7653

https://issues.apache.org/jira/browse/KAFKA-7653

Added two new types KeySerde[T] and ValueSerde[T] and changed signatures of the relevant methods to accept KeySerde and ValueSerde instead of Serde as implicit params.

Also added KeyValueAgnostic object to org.apache.kafka.streams.scala.Serdes, to provide implicit conversions from Key/ValueSerdes to plain old Serde to help minimise impact on existing users

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@guozhangwang @miguno @vvcephei

@mjsax mjsax added the streams label Nov 22, 2018
@vvcephei
Copy link
Contributor

Hi @mtranter,

Thanks for taking this on.

I thought the idea of the new types was to pre-configure the serdes as key or value, but I didn't see this in the code... Did I miss it, or did I miss the point?

Thanks,
-John

@bbejeck
Copy link
Contributor

bbejeck commented Mar 21, 2019

@mtranter any updates on this PR?

@mjsax mjsax added the kip Requires or implements a KIP label Jun 12, 2020
@mjsax
Copy link
Member

mjsax commented Dec 29, 2022

Closing this stale PR due to inactivity. It seems the corresponding KIP-513 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-513%3A+Distinguish+between+Key+and+Value+serdes+in+scala+wrapper+library+for+kafka+streams) as abandoned, too.

@mjsax mjsax closed this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kip Requires or implements a KIP streams
Projects
None yet
4 participants