Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7650: make auto.create.topics.enable dynamically configurable #5973

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

xiowu0
Copy link
Contributor

@xiowu0 xiowu0 commented Nov 29, 2018

KAFKA-7650: make auto.create.topics.enable dynamically configurable

tested auto.create.topics.enable can be dynamically configured after change.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@mrsrinivas mrsrinivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xiowu0 for the PR!!!

since this PR is related to public interface change, it requires KIP. Where the community have discussion and voting for it.

Please check this link: Kafka Improvement Proposals

thoughts @mjsax @omkreddy @guozhangwang?

@mrsrinivas
Copy link
Contributor

About code changes, Are we stopping the client in other scenario like this,

when auto.create.topics.enable=false at broker side especially in multi-tenant cluster, but client make the configuration to true and start creating as many topics as they want. That should not happen.

@xiowu0
Copy link
Contributor Author

xiowu0 commented Dec 13, 2018

About code changes, Are we stopping the client in other scenario like this,

when auto.create.topics.enable=false at broker side especially in multi-tenant cluster, but client make the configuration to true and start creating as many topics as they want. That should not happen.

If either client or broker don't allow auto topic creation, the auto topic creation will be disabled.

Setting this at broker side, it is sufficient to prevent auto topic creation. This configuration is only for auto topic creation, it doesn't affect the topic creation via create topic API.

@xiowu0
Copy link
Contributor Author

xiowu0 commented Dec 13, 2018

@mrsrinivas I don't know if it requires a KIP, since it is a very small change. It only makes existing configuration dynamic configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants