Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7698: Kafka Broker fail to start: ProducerFencedException throw… #5992

Closed

Conversation

mingaliu
Copy link
Contributor

@mingaliu mingaliu commented Dec 3, 2018

If ValidationType is None, also skip the check in appendEndTxnMarker (similar to append).

Verified with existing unitest and our daily operation.

…n from producerstatemanager.scala!checkProducerEpoch
@hachikuji hachikuji self-assigned this Dec 12, 2018
@hachikuji
Copy link
Contributor

hachikuji commented Dec 12, 2018

@mingaliu Thanks for the patch. I think it makes sense to skip all validation when loading the segments. That said, I'm a bit puzzled how the log could have gotten into that state. I don't suppose you can reproduce the problem or you have a dump of the log segments or anything?

@mingaliu
Copy link
Contributor Author

@hachikuji Thanks for the comments. I can't get the repro of this problem. This happened a few times in our production environment. And I only find this by reviewing the code.

@mingaliu mingaliu closed this Jan 18, 2019
@mingaliu mingaliu reopened this Jan 18, 2019
@mingaliu
Copy link
Contributor Author

Please review or sign off, @junrao , @hachikuji , thanks!

@hachikuji
Copy link
Contributor

@mingaliu My only hesitation is that we may be glossing over a deeper problem. The error suggests that we have hit a scenario in which the epoch validation did not work as expected. This could have rather severe consequences, so I would prefer to try to understand the underlying problem and fix it at the source. It would be helpful if the problem reoccurs to collect a dump of the log data for analysis.

@philipp94831
Copy link

@mingaliu @hachikuji Are there any plans to merge this PR? Our Kafka brokers cannot start due to the exact same issue and I have no idea how to get our Kafka cluster working again. I can provide some start-up logs if it helps

@hachikuji
Copy link
Contributor

I think we got to the bottom of this issue in #7687. I am going to close this PR and we will follow up there.

@hachikuji hachikuji closed this Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants