[KAFKA-7780] Kafka client should validate topic-level configs and update only unique values #6088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManoharVanam
changed the title
…ate only unique values
ManoharVanam
force-pushed
the
KAFKA-7780
branch
from
04ce285
to
c7b0b4d
Compare
ManoharVanam
changed the title
|
@hachikuji @omkreddy Please take a look when you get a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Interface Improvement : Kafka client should validate topic-level configs, and throw exception in case of invalid (duplicate) config values.
Example: ./kafka-topics.sh --create --topic test --partitions 2 --replication-factor 1 --zookeeper localhost:2181 --config cleanup.policy=delete,compact,delete
should throw exception like
Invalid value delete,compact,delete for configuration cleanup.policy: Contains duplicate values
Committer Checklist (excluded from commit message)