Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7160 Add check for group ID length #6098

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

rosama86
Copy link

@rosama86 rosama86 commented Jan 7, 2019

Description: validate group id length is <= 265 byte

Testing: added 2 test cases to validate behavior of using group-id = 265 [border] & group-id > 265

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rosama86 rosama86 force-pushed the KAFKA-7160-check-group-id-length branch from 91edbd2 to 4d90e9f Compare January 8, 2019 06:09
@rosama86 rosama86 force-pushed the KAFKA-7160-check-group-id-length branch from 4d90e9f to b849824 Compare January 8, 2019 06:28
@rosama86 rosama86 changed the title KAFKA-7160 Add check for group ID length WIP KAFKA-7160 Add check for group ID length Jan 8, 2019
@rosama86 rosama86 changed the title WIP KAFKA-7160 Add check for group ID length KAFKA-7160 Add check for group ID length Jan 8, 2019
@ijuma
Copy link
Contributor

ijuma commented Mar 4, 2019

Thanks for the PR. This change requires a KIP: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants