-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-7844: Fix installAll, jarAll, etc. targets #6169
Conversation
The presence of the buildSrc subproject is causing problems when we try to run installAll, jarAll, and the other "all" targets. It's easier just to make the generator code a regular subproject and use the JavaExec gradle task to run the code. This also makes it more straightforward to run the generator unit tests.
Checked this out locally and it fixed the IntelliJ errors I was seeing previously. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note that this also fixes IntelliJ not correctly handling some of the generator junit test files. |
build.gradle: The :generator module should not reference org.apache.kafka.test.IntegrationTest.IntegrationTest, since it resides in the client module which we may not have yet compiled.
The jenkins failures are consistent, seems relevant? |
Yeah, the errors are definitely related. |
Adding |
Merged #6182 with correct attribution, closing this one. |
The presence of the buildSrc subproject is causing problems when we try
to run installAll, jarAll, and the other "all" targets. It's easier
just to make the generator code a regular subproject and use the
JavaExec gradle task to run the code. This also makes it more
straightforward to run the generator unit tests.