KAFKA-7990: Close streams at the end in KafkaStreamsTest #6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guozhangwang Should we cherry-pick the old fix instead? Or is this not possible? |
mjsax
approved these changes
Feb 27, 2019
|
The original PR (5618) is a very big one that covers lots of files :) Many of them are either covered already or not added in older branches though. |
|
Thanks. LGTM. |
guozhangwang
added a commit
that referenced
this pull request
Feb 27, 2019
This fix is already in 2.1+ branches, but did not get into older branches. Should be cherry-picked all the way to 0.10.2. Reviewers: Matthias J. Sax <mjsax@apache.org>
guozhangwang
added a commit
that referenced
this pull request
Feb 27, 2019
This fix is already in 2.1+ branches, but did not get into older branches. Should be cherry-picked all the way to 0.10.2. Reviewers: Matthias J. Sax <mjsax@apache.org>
guozhangwang
added a commit
that referenced
this pull request
Feb 27, 2019
This fix is already in 2.1+ branches, but did not get into older branches. Should be cherry-picked all the way to 0.10.2. Reviewers: Matthias J. Sax <mjsax@apache.org>
guozhangwang
added a commit
that referenced
this pull request
Feb 27, 2019
This fix is already in 2.1+ branches, but did not get into older branches. Should be cherry-picked all the way to 0.10.2. Reviewers: Matthias J. Sax <mjsax@apache.org>
|
Cherry-picked to 1.1/1.0/0.11.0/0.10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is already in 2.1+ branches, but did not get into older branches.
Should be cherry-picked all the way to 0.10.2.
Committer Checklist (excluded from commit message)