MINOR: replication factor is short #6508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norwood
force-pushed
the
replication-factor-is-short
branch
2 times, most recently
from
572ab15
to
069beb3
Compare
|
test failures are related to the PR changes. |
norwood
force-pushed
the
replication-factor-is-short
branch
from
069beb3
to
8f2d2b4
Compare
|
how embarrassing. |
cmccabe
reviewed
Apr 2, 2019
| @@ -938,7 +938,7 @@ object KafkaConfig { | |||
|
|
|||
| /** ********* Replication configuration ***********/ | |||
| .define(ControllerSocketTimeoutMsProp, INT, Defaults.ControllerSocketTimeoutMs, MEDIUM, ControllerSocketTimeoutMsDoc) | |||
| .define(DefaultReplicationFactorProp, INT, Defaults.DefaultReplicationFactor, MEDIUM, DefaultReplicationFactorDoc) | |||
| .define(DefaultReplicationFactorProp, SHORT, Defaults.DefaultReplicationFactor, MEDIUM, DefaultReplicationFactorDoc) | |||
There was a problem hiding this comment.
This is an incompatible change which would require a KIP and a new major version.
|
Changing INT to SHORT in the publicly visible configs is an incompatible change which would require a KIP. And we'd have to do it in a new major version. Suggest removing that from the PR. |
|
I guess its technically incompatible, however if you currently have this set to IMO it seems like a bug fix to not let users get in to a bad state. but if you think it needs a KIP i'll write one up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replication factor is short on brokers, but there are many places it is typed in. this fixes that.
Committer Checklist (excluded from commit message)