Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7502: Cleanup KTable materialization logic in a single place (doTransformValues) #6519

Merged

Conversation

dongjinleekr
Copy link
Contributor

This PR is a follow-up of #6174 and #6453, which cleans up KTableImpl#doTransformValues method.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dongjinleekr dongjinleekr changed the title KAFKA-7502: Cleanup KTable materialization logic in a single place KAFKA-7502: Cleanup KTable materialization logic in a single place (doTransformValues) Mar 28, 2019
@dongjinleekr
Copy link
Contributor Author

cc/ @bbejeck @guozhangwang

@guozhangwang
Copy link
Contributor

retest this please

1 similar comment
@dongjinleekr
Copy link
Contributor Author

retest this please

Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dongjinleekr LGTM.

@bbejeck bbejeck merged commit d10023e into apache:trunk Mar 29, 2019
@bbejeck
Copy link
Contributor

bbejeck commented Mar 29, 2019

Merged #6519 into trunk.

jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
* apache/trunk:
  KAFKA-8030: Fix flaky tests in TopicCommandWithAdminClientTest
  fix compile error for example (apache#6526)
  MINOR: Comment spelling nit
  MINOR: Optimize ConnectionStressWorker
  KAFKA-8034: Use automatic RPC generation in DeleteTopics
  MINOR: Move KTable source topic for changelog to optimization framework (apache#6500)
  KAFKA-7502: Cleanup KTable materialization logic in a single place (doMapValues) (apache#6520)
  Cleanup KTableImpl#doTransformValues (apache#6519)
  MINOR: Streams input topic corrected (apache#6513)
  MINOR: WorkerUtils#abort: fix bug in abort logic (apache#6516)
  KAFKA-7502: Cleanup KTable materialization logic in a single place (filter) (apache#6453)
  MINOR: Fix some spelling corrections in comments (apache#6507)
  KAFKA-3522: Add RocksDBTimestampedSegmentedBytesStore (apache#6186)
  MINOR: Add 2.2.0 upgrade instructions (apache#6501)
Pengxiaolong pushed a commit to Pengxiaolong/kafka that referenced this pull request Jun 14, 2019
This PR is a follow-up of apache#6174 and apache#6453, which cleans up KTableImpl#doTransformValues method.

Reviewers: Bill Bejeck <bbejeck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants