KAFKA-2927: reduce system test storage footprint #657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect DEBUG by default
|
Running tests here: |
|
nice! LGTM |
| logs = { | ||
| "kafka_operational_logs": { | ||
| "path": OPERATIONAL_LOG_DIR, | ||
| "kafka_operational_logs_info": { |
There was a problem hiding this comment.
More general duckape thought about how this works -- should we always make these constants in the class? The way we use them now, I think this constant has to be copied into any test which wants to mark a specific log for collection, e.g., in the case of failure where it knows which files will be relevant for debugging. This seems brittle given changes like this. Do we know if the code that marks logs for collection will even fail if there had been tests that marked "kafka_operational_logs" for collection?
|
@granders Love the goal of the patch, just have a few questions re: the implementation. |
AnGg98
pushed a commit
to AnGg98/kafka
that referenced
this pull request
Jul 25, 2022
Reviewers: Manikumar Reddy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split kafka logging into two levels - DEBUG and INFO, and do not collect DEBUG by default.