KAFKA-3070: Use IBM Kerberos module for SASL tests if running on IBM JDK #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -216,6 +217,8 @@ object TestUtils extends Logging { | |||
|
|
|||
| if (protocolAndPorts.exists { case (protocol, _) => usesSslTransportLayer(protocol) }) | |||
| props.putAll(sslConfigs(Mode.SERVER, false, trustStoreFile, s"server$nodeId")) | |||
| if (protocolAndPorts.exists { case (protocol, _) => usesSaslTransportLayer(protocol) }) | |||
| props.put(KafkaConfig.SaslKerberosServiceNameProp, "kafka") | |||
There was a problem hiding this comment.
I'm wondering how this change is related to using the IBM JDK.
There was a problem hiding this comment.
@fpj Thank you for the review. serviceName is not a standard property of the Kerberos module and IBM Kerberos module throws an exception if this property is specified. The alternative configuration option for serviceName works with any JDK.
|
@rajinisivaram I had a look at the changes, they look good. I've left couple of questions above. |
rajinisivaram
force-pushed
the
KAFKA-3070
branch
from
f9fc14d
to
47f0ad5
Compare
|
@fpj I have answered your questions above. Are you ok with these changes? |
|
Closing PR since this is out of date now. |
|
@rajinisivaram Is it ok if we grab your changes and submit a new PR for this ? |
|
@mimaison Yes, of course. |
mimaison
added a commit
to mimaison/kafka
that referenced
this pull request
May 12, 2017
Use IBM Kerberos module for SASL tests if running on IBM JDK Developed with @edoardocomar Based on apache#738 by @rajinisivaram
asfgit
pushed a commit
that referenced
this pull request
May 18, 2017
Use IBM Kerberos module for SASL tests if running on IBM JDK Developed with edoardocomar Based on #738 by rajinisivaram Author: Mickael Maison <mickael.maison@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Rajini Sivaram <rajinisivaram@googlemail.com>, Edoardo Comar <ecomar@uk.ibm.com> Closes #2878 from mimaison/KAFKA-3070
lbradstreet
added a commit
to lbradstreet/kafka
that referenced
this pull request
Jul 16, 2022
… instances (apache#12382) (apache#738) When running with 4th generation instances supporting EBS only, we need to use a larger volume or else we run out of disk space during a system test run. This change also parameterizes the instance type as an env variable for easier testing. Reviewers: David Jacot <djacot@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use IBM Kerberos module and properties for SASL tests if using IBM JRE