Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix static membership link in Streams upgrade notes #7439

Merged
merged 1 commit into from Dec 18, 2019

Conversation

mimaison
Copy link
Member

@mimaison mimaison commented Oct 3, 2019

Fix broken link in Streams docs.
Same as 11337af#diff-8100f2416b657c1e1e4238dabf8a15e0

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mimaison
Copy link
Member Author

mimaison commented Oct 3, 2019

cc @omkreddy

@mimaison
Copy link
Member Author

@mjsax Can you take a look?

Copy link
Contributor

@omkreddy omkreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mimaison Thanks for the PR. LGTM.

Copy link
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @mimaison !

@vvcephei
Copy link
Contributor

The results from the failed build are gone by now, but this is a docs-only change.

@vvcephei vvcephei merged commit c6e25bb into apache:trunk Dec 18, 2019
@vvcephei
Copy link
Contributor

@mimaison , could you also mirror the change in kafka-site? Thanks!

@omkreddy
Copy link
Contributor

If we are updating kafka-site, Please also cherry-pick to 2.4.

@mimaison mimaison deleted the static-membership-link branch December 18, 2019 17:41
@mimaison
Copy link
Member Author

Once merged, I'm happy to open a PR to fix all these in kafka-site

@mimaison
Copy link
Member Author

@vvcephei I've opened apache/kafka-site#246 so you can go ahead and merge in 2.4 too

@mjsax
Copy link
Member

mjsax commented Dec 19, 2019

Thanks for all the cleanup @mimaison!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants