KAFKA-8969 Log the partition being made online due to unclean leader election. #7440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jsancio |
jsancio
reviewed
Oct 7, 2019
There was a problem hiding this comment.
Thanks for the PR @smccauliff. Just a few minor suggestions.
| } | ||
| } else { | ||
| None | ||
| } |
There was a problem hiding this comment.
This formatting doesn't seem correct. How about:
assignment
.find(id => liveReplicas.contains(id) && isr.contains(id))
.map((_, false)) // or .map(_ -> false) or .map(id => (id, false))
.orElse {
if (uncleanLeaderElectionEnabled) {
assignment.find(liveReplicas.contains).map((_, true))
else {
None
}
}There was a problem hiding this comment.
This won't compile. At least on scala 2.11. The compiler thinks the type for the first type parameter of the tuple is Any or something else.
|
retest this please |
Formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactor to PartitionLeaderElectionAlgorithms and Election to move side effects outside of PartitionLeaderElectionAlgorithms and into higher level Election.
Added a unit test to the PartitionStateMachine to verify that unclean leader election correctly assigns a partition and increments the ule metric.