Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Add wait condition for state RUNNING to avoid flakiness #7476

Merged
merged 1 commit into from Oct 10, 2019
Merged

MINOR: Add wait condition for state RUNNING to avoid flakiness #7476

merged 1 commit into from Oct 10, 2019

Conversation

cadonna
Copy link
Contributor

@cadonna cadonna commented Oct 9, 2019

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@cadonna
Copy link
Contributor Author

cadonna commented Oct 9, 2019 •
edited

Call for review: @mjsax @ableegoldman @abbccdda @cpettitt-confluent

cpettitt-confluent
cpettitt-confluent approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@cpettitt-confluent cpettitt-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It seems that the two benefits of this patch are: 1) getting a more accurate error message if the streams app did not transition to running in the 30 second timeout, 2) effectively extending the test timeout from 30 seconds to between 30-60 seconds.

abbccdda
abbccdda approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@abbccdda abbccdda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cadonna
Copy link
Contributor Author

cadonna commented Oct 10, 2019

In JDK 8/Scala 2.11, the following tests failed:

kafka.api.SaslOAuthBearerSslEndToEndAuthorizationTest.testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl
org.apache.kafka.streams.integration.KTableKTableForeignKeyJoinIntegrationTest.doLeftJoinFromRightThenDeleteRightEntity

Retest this, please

@mjsax
Copy link
Member

mjsax commented Oct 10, 2019

Java 8 passed.

Java 11 / 2.12: kafka.api.SaslSslAdminClientIntegrationTest.testCreateTopicsResponseMetadataAndConfig
Java 11 / 2.13: kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

@mjsax mjsax merged commit c3177a1 into apache:trunk Oct 10, 2019
@mjsax mjsax added streams tests Test fixes (including flaky tests) labels Oct 10, 2019
@mjsax mjsax mentioned this pull request Oct 11, 2019
Merged
@cadonna
Copy link
Contributor Author

cadonna commented Oct 11, 2019

@mjsax Should we also cherry-pick this PR to 2.4 and 2.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbccdda abbccdda abbccdda approved these changes

@cpettitt-confluent cpettitt-confluent cpettitt-confluent approved these changes

Assignees
No one assigned
Labels
streams tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
4 participants
@cadonna @mjsax @abbccdda @cpettitt-confluent