MINOR: ListPartitionReassignmentsResponse should not be entirely failed when a topic-partition does not exist #7486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse when a topic partition does not exist but rather return nothing for it.
|
LGTM |
|
JDK 11 and Scala 2.13 had two failing tests:
They are not related to changes made by this PR. |
|
In the future, it's good to make sure to update the KIP. I did so already fwiw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a ListPartitionReassignmentsRequest containing a non-existing topic-partition is sent to the controller, the controller returns a ListPartitionReassignmentsResponse with the top level error code set to UNKNOWN_TOPIC_OR_PARTITION. If multiple topic-partitions are passed in the same request, the caller has no way to know which ones do not exist any more. It has to use another admin call to figure it out and then retries the former.
Instead, the controller should ignore any non-existing topic-partitions. It is fine because they don't have any reassignments by definition so the contract of the API remains valid.
Committer Checklist (excluded from commit message)