Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-8988. Replace CreatePartitions Request/Response with automated protocol #7493

Merged

Commits on Jan 6, 2020

  1. KAFKA-8988. Replace CreatePartitions Request/Response with automated …

    …protocol
    
    This change update the CreatePartitions request and response api objects
    to use automated protocol. The change involved updating all client code
    to use the newly updated CreatePartitionsRequest and
    CreatePartitionsResponse classes.
    
    Updated relevant tests. All tests pass.
    soondenana committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    d2e4a57 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e0143a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e51140 View commit details
    Browse the repository at this point in the history
  4. Take care of latest round of review comments

    The commit contain three changes:
    
    1. Rename "integers" variable to "brokerIds"
    2. Take out "()" from method calls as per coding convention
    3. Refactor AdminManager::createPartitions to get rid of chained maps.
    soondenana committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    6d469f0 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Don't filter out empty partition reassignment

    Empty reassignment was treated as error condition before, filtering it
    out now ignores this case and creates new partiton using default
    assignment.
    
    This change removes that filter, so that the error condition is
    triggered again and `InvalidReplicaAssignmentException` gets thrown.
    soondenana committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    0128e03 View commit details
    Browse the repository at this point in the history