KAFKA-9171: Handle ReplicaNotAvailableException during DelayedFetch #7678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
reviewed
Nov 11, 2019
| @@ -139,6 +140,9 @@ class DelayedFetch(delayMs: Long, | |||
| case _: NotLeaderForPartitionException => // Case A | |||
| debug("Broker is no longer the leader of %s, satisfy %s immediately".format(topicPartition, fetchMetadata)) | |||
| return forceComplete() | |||
| case _: ReplicaNotAvailableException => // Case H | |||
| debug("Broker no longer has a replica of %s, satisfy %s immediately".format(topicPartition, fetchMetadata)) | |||
There was a problem hiding this comment.
Can we use string interpolation? We do it for 3 of the other cases, but not the one immediately above. Also, should this be case B and shift the rest instead of case H? It seems like it would be easier to understand if the first 3 cases were about leader/replica/partition knowledge. Also, we could have the case checks in order: A, B, C, etc.
What do you think?
There was a problem hiding this comment.
@ijuma Thanks for the review, updated.
ijuma
approved these changes
Nov 11, 2019
|
@ijuma Thanks for the review. Have confirmed that none of the exceptions in the catch block are subclasses of another exception in the catch block. |
|
@ijuma Thanks for the review, merging to trunk and 2.4. |
rajinisivaram
added a commit
that referenced
this pull request
Nov 11, 2019
…7678) Reviewers: Ismael Juma <ismael@juma.me.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)