Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7588: Pass custom configs to the ChannelBuilder implementations #7794

Merged
merged 1 commit into from Dec 12, 2019

Conversation

omkreddy
Copy link
Contributor

@omkreddy omkreddy commented Dec 6, 2019

This PR ensures we provide custom configs to ChannelBuilder implementations apart from config.values() we pass currently.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@rajinisivaram rajinisivaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omkreddy Thanks for the PR, LGTM
@mimaison Since you raised the JIRA, can you also review this PR please?

@rajinisivaram
Copy link
Contributor

@omkreddy Since @mimaison hasn't responded, I will merge this to trunk. If there are additional comments, we can address them in a follow-on PR.

@rajinisivaram rajinisivaram merged commit ae2e7be into apache:trunk Dec 12, 2019
@mimaison
Copy link
Member

Sorry I meant to take a look!
Are there any pluggable APIs left that don't get custom configs?

@omkreddy
Copy link
Contributor Author

@mimaison This covers all below listed security related pluggable interfaces. looks like for all other interfaces, we already passing all original configs.

  • principal.builder.class
  • sasl.login.callback.handler.class
  • sasl.login.class
  • sasl.server.callback.handler.class
  • sasl.client.callback.handler.class
  • security.providers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants