[WIP]KAFKA-8733 Initial sketch of the solution mentioned in KIP-501. #7802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedyu
reviewed
Jan 22, 2020
| if (x <= 0) throw new IllegalStateException("value should not be < 0") | ||
| else { | ||
| if (x > 1) delegate.put(offset, x - 1) | ||
| true |
There was a problem hiding this comment.
When x==1, there is no adjustment ?
satishd
force-pushed
the
KAFKA-8733
branch
3 times, most recently
from
2d10e73
to
235c79a
Compare
Leader partition maintains follower replica state which is added with pending fetch requests that are to be processed for fetch offsets >= log-end-offset in the earlier fetch request. Follower replica is considered to be insync if there are any such pending fetch requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leader partition maintains follower replica state which is added with pending fetch requests that are to be processed for fetch offsets >= log-end-offset in the
earlier fetch request. Follower replica is considered to be insync if there are any such pending fetch requests.
Committer Checklist (excluded from commit message)