Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-8037: Added deserialization check on restoration of global state stores from source topics #7923

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

pkleindl
Copy link
Contributor

@pkleindl pkleindl commented Jan 9, 2020

@vvcephei @guozhangwang First part for global state stores.
A check for normal changelog topics is included, in this case the check is not performed.

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@vvcephei
Copy link
Contributor

@pkleindl , just to clarify, is this PR a self-contained set of changes we can review and merge, or do you plan to make further changes to it?

@guozhangwang , can you take the lead on reviewing this? One thing I'd like to explore is figuring out how to expose the information from the InternalTopologyBuilder to the StateManager directly about whether the "changelog" is a source topic or a real changelog. Right now, @pkleindl is using string matching for lack of a good alternative, which should work but is also brittle.

@pkleindl
Copy link
Contributor Author

@vvcephei This PR is only for global state stores and works on its own.
From what I have analyzed in the code for the local state stores this is not easily usable there.
I'll write my findings in the JIRA issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants