Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-3125: Add Kafka Streams Exceptions #809

Closed
wants to merge 3 commits into from
Closed

KAFKA-3125: Add Kafka Streams Exceptions #809

wants to merge 3 commits into from

Conversation

guozhangwang
Copy link
Contributor

No description provided.

@guozhangwang
Copy link
Contributor Author

A few changes with this PR:

  1. Avoid wrapping all exceptions in the StreamThread, but instead only StreamsExceptions (this is the top-level exception type of Kafka Streams); other exceptions will be treated as user app code exceptions.
  2. KafkaStreams.start() / close() should not throw any exceptions; all exceptions thrown will be in the StreamThread, which will only stop that thread, and other threads will continue to run until KafkaStreams.close() is called.
  3. Also fixed the issue in KAFKA-3142.

ewencp
ewencp reviewed Jan 26, 2016
View reviewed changes
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamJoinWindow.java
this.retentionPeriodMs = retentionPeriodMs;

if (windowSizeMs * 2 > retentionPeriodMs)
throw new KafkaException("The retention period of the join window "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the exception in AbstractStream is a TopologyBuilderException, why isn't this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack.

@guozhangwang
Copy link
Contributor Author

@ewencp Mind taking another look?

@ewencp
Copy link
Contributor

ewencp commented Jan 26, 2016

LGTM

@asfgit asfgit closed this in 5ae9719 Jan 26, 2016
@guozhangwang guozhangwang deleted the K3125 branch October 7, 2016 21:46
ableegoldman pushed a commit to ableegoldman/kafka that referenced this pull request Oct 21, 2022
@cadonna
Add ksql to CODEOWNERS (apache#809)
9e4dc60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@guozhangwang @ewencp