KAFKA-9580: Log clearer error messages when there is an offset out of range (Broker & Client Change) #8152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctan888
changed the title
ctan888
changed the title
soondenana
reviewed
Feb 28, 2020
ctan888
changed the title
hachikuji
reviewed
Mar 11, 2020
.../src/main/java/org/apache/kafka/common/errors/OffsetOutOfRangeExceptionWithOffsetValues.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
Outdated
Show resolved
Hide resolved
hachikuji
reviewed
Mar 11, 2020
ctan888
force-pushed
the
BrokerChange
branch
3 times, most recently
from
a04aa55
to
67f4bd7
Compare
soondenana
reviewed
Mar 24, 2020
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
Outdated
Show resolved
Hide resolved
soondenana
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
Broker side: Added an Info level log when throwing the offsetOutOfRangeException in log.scala. Also, utilized a new error class OffsetOutOfRangeExceptionWithOffsetValues, a subclass of OffsetOutOfRangeException, as a media to pass offset values into the response to the consumer client.
Client side: Added an Info level log when the fetcher gets OffsetOutOfRangeExceptionWithOffsetValues, which is the subclass of OffsetOutOfRangeException.
Summary of testing strategy (including rationale)
I changed the source code and deliberately threw offsetOutOfRangeException on the broker side. Then, I started the kafka console producer & consumer and receives:
INFO [Log partition=test-0, dir=/tmp/kafka-logs] Received request for offset 0 for partition test-0, but we only have log segments in the range 0 to 40. (kafka.log.Log)on the broker console and
INFO [Consumer clientId=consumer-console-consumer-28016-1, groupId=console-consumer-28016] Fetch offset 0 is out of range for partition test-0. We only have log segments in the range from 0 to 40. Resetting offset (org.apache.kafka.clients.consumer.internals.Fetcher)on the client console, which means the client successfully gets the logStartOffset and lastStableOffset of the partition, even when the broker throws OffsetOutOfRangeException.